feat(tokens): use typescript in the tokens package #5557
Conversation
|
|
Related Previews |
|
|
||
| if (meta.layer === 'semantic') { | ||
| const baseSetName = meta.setNames[0]; | ||
| const overrideSetNameIndex = meta.setNames.findIndex(setName => setName === currentSetName); | ||
| const overrideSetNameIndex = meta.setNames.findIndex( | ||
| (setName: string) => setName === currentSetName, |
There was a problem hiding this comment.
Same here, the : string would not be necessary if options are of the correct type.
There was a problem hiding this comment.
the :string is still there
…ithub.com/swisspost/design-system into 4499-use-typescript-in-the-tokens-package
| @@ -48,7 +49,7 @@ StyleDictionary.registerFormat({ | |||
| const utilityTokens = new Map(); | |||
|
|
|||
| dictionary.allTokens.forEach(token => { | |||
| const { subitem, state } = token.attributes; | |||
| const { subitem, state } = token.attributes || {}; | |||
There was a problem hiding this comment.
This hides the typing error but it doesn't really fix it.
token.attributes is generally defined as Record<string, unknown> but we should specify it more to reflect what we get, which is something like this:
attributes: {
category: 'typo',
type: 'post',
item: 'utility',
subitem: 'font-size',
state: '11'
},
| ], | ||
| }); | ||
|
|
||
| config.platforms = Object.entries(config.platforms).reduce( | ||
| config.platforms = Object.entries(config.platforms || {}).reduce( |
There was a problem hiding this comment.
This would hide a bug if config.platforms were to not be defined. It might be better to throw an error if config.platforms isn't defined instead. What do you think?
Something like this beforehand:
if (!config.platforms) return;
|
|
||
| if (meta.layer === 'semantic') { | ||
| const baseSetName = meta.setNames[0]; | ||
| const overrideSetNameIndex = meta.setNames.findIndex(setName => setName === currentSetName); | ||
| const overrideSetNameIndex = meta.setNames.findIndex( | ||
| (setName: string) => setName === currentSetName, |
There was a problem hiding this comment.
the :string is still there
|
📄 Description
This PR implements Typescript in the Tokens Package.
📝 Checklist