feat(eslint): automigration rules to update gutter utilities #6237
+153
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be959ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
4 tasks
…4-migration-rules-for-the-gutter-utility
Base automatically changed from
6020-migration-rules-for-the-sizing-utilities
to
main
September 26, 2025 10:48
alizedebray
requested changes
Oct 2, 2025
Comment on lines
+81
to
+86
| export function createTwoPhasesRules( | ||
| data: TwoPhasesData, | ||
| name: string, | ||
| descriptionPhase1: string, | ||
| descriptionPhase2: string, | ||
| ): { |
There was a problem hiding this comment.
Can you change this function signature to something like this:
Suggested change
| export function createTwoPhasesRules( | |
| data: TwoPhasesData, | |
| name: string, | |
| descriptionPhase1: string, | |
| descriptionPhase2: string, | |
| ): { | |
| type RuleType = Rule.RuleMetaData['type']; | |
| type RuleMessages = Rule.RuleMetaData['messages']; | |
| interface RuleConfigBase { | |
| name: string; | |
| type?: RuleType; | |
| } | |
| interface PhaseConfig<T>{ | |
| description: string; | |
| messages: T; | |
| mutations: Record<keyof T, [string] | [string, string]>; | |
| } | |
| interface TwoPhaseRuleConfig<T, U> extends RuleConfigBase { | |
| phases: [PhaseConfig<T>, PhaseConfig<U>]; | |
| } | |
| const createTwoPhasesClassUpdateRule = <T extends RuleMessages, U extends RuleMessages>( | |
| config: TwoPhaseRuleConfig<T, U> | |
| ): { |
This way, descriptions are included into the phase data and we ensure message keys and mutation keys are always matching.
Then the RuleConfig interface could be turned into:
type SinglePhaseRuleConfig<T> = RuleConfigBase & PhaseConfig<T>;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
Automigration rules for the gutter utility + two phase rules refactoring