Skip to content

[MCP Bundle] Make MonologBundle optional #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+40 −17
Open

[MCP Bundle] Make MonologBundle optional #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fa5c11
Make MonologBundle optional in McpBundle
camilleislasse Nov 13, 2025
ecea6d6
Conditionally call Builder->setLogger() only when MonologBundle exi…
camilleislasse Nov 14, 2025
a8500ca
Add MonologBundle to require-dev to ensure tests run in CI
camilleislasse Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/mcp-bundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"require-dev": {
"phpstan/phpstan": "^2.1",
"phpstan/phpstan-strict-rules": "^2.0",
"phpunit/phpunit": "^11.5"
"phpunit/phpunit": "^11.5",
"symfony/monolog-bundle": "^3.10"
},
"minimum-stability": "dev",
"prefer-stable": true,
Expand Down
23 changes: 16 additions & 7 deletions src/mcp-bundle/config/services.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,33 @@

use Mcp\Server;
use Mcp\Server\Builder;
use Symfony\Bundle\MonologBundle\MonologBundle;

return static function (ContainerConfigurator $container): void {
$container->services()
->set('monolog.logger.mcp')
->parent('monolog.logger_prototype')
->args(['mcp'])
->tag('monolog.logger', ['channel' => 'mcp'])
if (class_exists(MonologBundle::class)) {
$container->services()
->set('monolog.logger.mcp')
->parent('monolog.logger_prototype')
->args(['mcp'])
->tag('monolog.logger', ['channel' => 'mcp'])
;
}

$builderDefinition = $container->services()
->set('mcp.server.builder', Builder::class)
->factory([Server::class, 'builder'])
->call('setServerInfo', [param('mcp.app'), param('mcp.version')])
->call('setPaginationLimit', [param('mcp.pagination_limit')])
->call('setInstructions', [param('mcp.instructions')])
->call('setLogger', [service('monolog.logger.mcp')])
->call('setEventDispatcher', [service('event_dispatcher')])
->call('setSession', [service('mcp.session.store')])
->call('setDiscovery', [param('kernel.project_dir'), param('mcp.discovery.scan_dirs'), param('mcp.discovery.exclude_dirs')])
->call('setDiscovery', [param('kernel.project_dir'), param('mcp.discovery.scan_dirs'), param('mcp.discovery.exclude_dirs')]);

if (class_exists(MonologBundle::class)) {
$builderDefinition->call('setLogger', [service('monolog.logger.mcp')]);
}

$container->services()
->set('mcp.server', Server::class)
->factory([service('mcp.server.builder'), 'build'])

Expand Down
6 changes: 4 additions & 2 deletions src/mcp-bundle/src/Command/McpCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,16 @@ class McpCommand extends Command
{
public function __construct(
private readonly Server $server,
private readonly LoggerInterface $logger,
private readonly ?LoggerInterface $logger = null,
) {
parent::__construct();
}

protected function execute(InputInterface $input, OutputInterface $output): int
{
$transport = new StdioTransport(logger: $this->logger);
$transport = $this->logger
? new StdioTransport(logger: $this->logger)
: new StdioTransport();
Comment on lines +34 to +36
Copy link

@WebMamba WebMamba Nov 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you thinks instead of having the NullLogger logic here: https://github.com/modelcontextprotocol/php-sdk/pull/152/files to have it here ?

Suggested change
$transport = $this->logger
? new StdioTransport(logger: $this->logger)
: new StdioTransport();
$transport = new StdioTransport(logger: $this->logger === null ? NullLogger() : $this->logger)

Copy link

@WebMamba WebMamba Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry the reviews are in the wrong order I miss clicked 😅

$this->server->run($transport);

return Command::SUCCESS;
Expand Down
18 changes: 12 additions & 6 deletions src/mcp-bundle/src/Controller/McpController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,18 @@ public function __construct(

public function handle(Request $request): Response
{
$transport = new StreamableHttpTransport(
$this->httpMessageFactory->createRequest($request),
$this->responseFactory,
$this->streamFactory,
logger: $this->logger,
);
$transport = $this->logger
? new StreamableHttpTransport(
$this->httpMessageFactory->createRequest($request),
$this->responseFactory,
$this->streamFactory,
logger: $this->logger,
Copy link

@WebMamba WebMamba Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here you can pass the NullLogger instead ?

)
: new StreamableHttpTransport(
$this->httpMessageFactory->createRequest($request),
$this->responseFactory,
$this->streamFactory,
);

return $this->httpFoundationFactory->createResponse(
$this->server->run($transport),
Expand Down
2 changes: 1 addition & 1 deletion src/mcp-bundle/src/McpBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ private function configureClient(array $transports, array $httpConfig, Container
$container->register('mcp.server.command', McpCommand::class)
->setArguments([
new Reference('mcp.server'),
new Reference('logger'),
new Reference('monolog.logger.mcp', ContainerInterface::NULL_ON_INVALID_REFERENCE),
])
->addTag('console.command');
}
Expand Down
5 changes: 5 additions & 0 deletions src/mcp-bundle/tests/DependencyInjection/McpBundleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\TestCase;
use Symfony\AI\McpBundle\McpBundle;
use Symfony\Bundle\MonologBundle\MonologBundle;
use Symfony\Component\DependencyInjection\ContainerBuilder;

class McpBundleTest extends TestCase
Expand Down Expand Up @@ -49,6 +50,10 @@ public function testCustomConfiguration()

public function testMcpLoggerServiceIsCreated()
{
if (!class_exists(MonologBundle::class)) {
$this->markTestSkipped('MonologBundle is not installed');
}

Comment on lines +53 to +56
Copy link

@WebMamba WebMamba Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since monolog is never installed on the ci, this test will be always skipped, so the rest of the test is useless. What do you think about requiring monolog on dev then?

Copy link
Contributor Author

@camilleislasse camilleislasse Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a8500ca

$container = $this->buildContainer([]);

$this->assertTrue($container->hasDefinition('monolog.logger.mcp'));
Expand Down
Loading