[Testing] Documented the changes in MailerAssertionsTrait #13050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Feb 4, 2020
HeahDude
reviewed
Feb 4, 2020
| when using `symfony/panther`_ for end-to-end testing. | ||
| The following assertions only work if a request has been made with the | ||
| ``Client`` in a test case extending the ``WebTestCase`` class. They are not | ||
| available either when using `symfony/panther`_ for end-to-end testing. |
There was a problem hiding this comment.
Sounds weird to use either without a following or. A left over? I think we should remove it and just say "not available when".
javiereguiluz
force-pushed
the
fix_13044
branch
from
b4d94b7 to
5b0590e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13044.