[Map] Add "color" support for SVG and UX Icon icons #3079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
requested changes
Sep 15, 2025
| protected IconType $type, | ||
| protected int $width = 24, | ||
| protected int $height = 24, | ||
| protected ?string $color = null, // Nouvelle propriété pour la couleur |
There was a problem hiding this comment.
The comment does not bring any value
Suggested change
| protected ?string $color = null, // Nouvelle propriété pour la couleur | |
| protected ?string $color = null, |
Comment on lines
+94
to
+95
| * Note: This only has an effect on SvgIcon and UxIcon types when rendered client-side by the JavaScript controller. | ||
| * The color should be a valid CSS color string (e.g., 'red', '#FF0000', 'rgb(255,0,0)'). |
There was a problem hiding this comment.
Suggested change
| * Note: This only has an effect on SvgIcon and UxIcon types when rendered client-side by the JavaScript controller. | |
| * The color should be a valid CSS color string (e.g., 'red', '#FF0000', 'rgb(255,0,0)'). | |
| * Must be a valid CSS color (e.g.: 'red', '#FF0000', 'rgb(255,0,0)'). Only affects UX Icon or SVG icons. |
| 'type' => $this->type->value, | ||
| 'width' => $this->width, | ||
| 'height' => $this->height, | ||
| 'color' => $this->color, // Ajout de la couleur au tableau de sérialisation |
There was a problem hiding this comment.
The comment does not bring any value
Suggested change
| 'color' => $this->color, // Ajout de la couleur au tableau de sérialisation | |
| 'color' => $this->color, |
carsonbot
added
Status: Needs Work
carsonbot
changed the title
Kocal
changed the title
smnandre
requested changes
Sep 20, 2025
There was a problem hiding this comment.
I'm sorry but for now we cannot accept this PR.
We cannot add a specific non typed/non-validated field on an central object without tests nor full working usage...
Did you try to use metadata on your markers ? Or to follow the other guidelines / advises given on your issue ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonjour,
Désolé je ne sais pas trop ou faire ceci et j'espère ne pas tout casser.
Est ce possible de rajouter cette fonction couleur sur l'icon ?
Merci