Refactor MultiResultCard to remove implicit state #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the git clone URL from git:// to https:// to resolve connection issues during the build process.
- Introduce a new CardResult class to encapsulate card evaluation results - Modify MultiResultCard's eval method to use CardResult instances - Update MultiResultCard's format_output method to handle CardResult instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the design of the
MultiResultCardclass to make state more explicit, as was requested in a "TODO" comment. It does this by adding theCardResultclass to encapsulate the relevant state of a card evaluation in a single object.The
evalmethod now createsCardResultobjects and adds them to a list ofresultsinstead of tuples, and it checks for the presence ofcard_resultobjects inresultsusing the__eq__method defined in theCardResultclass.The
format_outputmethod now takes a list ofCardResultobjects instead of tuples, and uses thecard_resultobject's attributes to generate the formatted output.