Notifications settings #427
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Waiting for #413 E2E tests being updated |
# Conflicts: # app/src/main/java/to/bitkit/ui/screens/wallets/HomeScreen.kt
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveLiquidityScreen.kt
Fixed
Show fixed
Hide fixed
…o feat/notifications-settings
# Conflicts: # app/src/main/java/to/bitkit/ui/screens/wallets/HomeNav.kt # app/src/main/java/to/bitkit/ui/screens/wallets/HomeScreen.kt
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveLiquidityScreen.kt
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Pull Request Overview
This PR implements notification settings for Bitkit's Lightning wallet, specifically focusing on background setup operations for CJIT (Custom-Jit) channels and spending transfers. It introduces notification permission handling and UI switches to enable "setup in background" functionality.
- Adds notification permission management across multiple Lightning-related flows
- Introduces "Setup in background" switches for CJIT and transfer operations
- Adds a home screen suggestion card to prompt users to enable notifications
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| strings.xml | Adds notification-related string resources for the suggestion card |
| ReceiveSheet.kt | Integrates notification permission state with CJIT liquidity screens |
| ReceiveLiquidityScreen.kt | Adds notification switch UI and permission handling to liquidity setup |
| ReceiveConfirmScreen.kt | Adds notification switch to CJIT confirmation screen |
| HomeViewModel.kt | Includes notifications suggestion in home screen suggestions |
| HomeScreen.kt | Handles navigation for notification settings from suggestion card |
| SpendingConfirmScreen.kt | Adds notification switch to spending transfer confirmation |
| SettingsSwitchRow.kt | Enhances switch component to accept custom colors |
| Suggestion.kt | Defines the new NOTIFICATIONS suggestion card |
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveLiquidityScreen.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveLiquidityScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveConfirmScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/transfer/SpendingConfirmScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/transfer/SpendingConfirmScreen.kt
Show resolved
Hide resolved
|
testes transfer and liquidity flow, but can't upload the videos |
|
Tested CJIT ✅ |
There was a problem hiding this comment.
LGTM, except that one little issue from the comment, on CJIT 'ReceiveLiquidityScreen' 👍🏻
nit: There's also some spacing improvements that could've been done on SpendingConfirmScreen to match FIGMA closer in terms of top and bottom space for the new switch, and the text should always be Set up in background but it is Setup in background.
If you want I can make the commits for these 👍🏻
app/src/main/java/to/bitkit/ui/screens/transfer/SpendingConfirmScreen.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveLiquidityScreen.kt
Show resolved
Hide resolved
2 participants
Roadmap item
FIGMA - CJIT
FIGMA - CJIT LEARN MORE
FIGMA - TRANSFER TO SPENDING
FIGMA - TRANSFER TO SPENDING ADVANCED
FIGMA - ADD LIQUIDITY
FIGMA - HOME SUGGESTION
Description
Preview
home_suggestion.webm
Uploading transfer.webm…
QA Notes
Tested: