Move sheets to parent view #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsIntroScreen.kt
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Pull Request Overview
This PR moves sheet management functionality from the HomeViewModel to the parent AppViewModel, centralizing sheet handling in the application architecture. This refactoring allows for better consistency and global sheet management across different screens.
Key Changes
- Sheet handling logic moved from
HomeViewModeltoAppViewModelwith timed sheet functionality - Various sheet components refactored to remove their own BottomSheet wrappers
- Updated function signatures to use named parameters for better clarity
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| AppViewModel.kt | Added comprehensive timed sheet management with state tracking and queue processing |
| HomeViewModel.kt | Removed all sheet-related logic, keeping only core home screen functionality |
| HomeScreen.kt | Updated to use AppViewModel for sheet management instead of HomeViewModel |
| ContentView.kt | Added TimedSheet handling with specific logic for each sheet type |
| Sheet components | Refactored to remove individual BottomSheet wrappers and use modifier parameter |
| SheetHost.kt | Added TimedSheetType enum and TimedSheet sealed class |
jvsena42
commented
Oct 13, 2025
Comment on lines
-53
to
-55
| RequestNotificationPermissions { granted -> | ||
| settingsViewModel.setNotificationPreference(granted) | ||
| } |
There was a problem hiding this comment.
The lint was complaining because this is a composable and this pattern is used to display content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preview
optional_update.webm
critical_update.webm
backup_and_high_balance.webm
quick_pay_and_notifications.webm
QA Notes