Skip to content

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Aug 23, 2025

Just found an oversight from #887

Mingun added 2 commits August 23, 2025 16:56
…ich is UTF-8 encoded as [c2 xx], except [c2 85]
…orresponding methods

HTML: https://html.spec.whatwg.org/#normalize-newlines
XML 1.0: https://www.w3.org/TR/xml/#sec-line-ends
XML 1.1: https://www.w3.org/TR/xml11/#sec-line-ends

XML 1.0 and HTML normalizes only \r and \r\n to \n
XML 1.1 additionally normalizes \r\x85, \x85 and \u2028 to \n
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.16%. Comparing base (38b44d4) to head (cd6f813).
⚠️ Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
src/events/mod.rs 44.44% 15 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   55.52%   58.16%   +2.64%     
==========================================
  Files          42       42              
  Lines       15511    15259     -252     
==========================================
+ Hits         8613     8876     +263     
+ Misses       6898     6383     -515     
Flag Coverage Δ
unittests 58.16% <77.27%> (+2.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mingun Mingun added the bug label Aug 23, 2025
@Mingun Mingun merged commit e7fa0ce into tafia:master Aug 24, 2025
7 checks passed
@Mingun Mingun deleted the fix-eol-normalization branch August 24, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants