Skip to content

Support <summary> as a focusable element #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 3, 2025
Merged

Support <summary> as a focusable element #3389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2931238
Add `summary` tag to all `focusableSelector` vars
Jul 16, 2024
29d101c
`summary` is only focusable as a direct child of `details`
RobinMalfait Sep 3, 2025
781c979
update changelog
RobinMalfait Sep 3, 2025
40ca588
`details` is focusable, if there is no direct `summary`
RobinMalfait Sep 3, 2025
88a10af
update changelog
RobinMalfait Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@headlessui-react/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Ensure we are not freezing data when the `static` prop is used ([#3779](https://github.com/tailwindlabs/headlessui/pull/3779))
- Ensure `onChange` types are contravariant instead of bivariant ([#3781](https://github.com/tailwindlabs/headlessui/pull/3781))
- Support `<details>` as a focusable element without `<summary>` ([#3389](https://github.com/tailwindlabs/headlessui/pull/3389))
- Support `<summary>` as a focusable element inside `<details>` ([#3389](https://github.com/tailwindlabs/headlessui/pull/3389))

## [2.2.7] - 2025-07-30

Expand Down
2 changes: 2 additions & 0 deletions packages/@headlessui-react/src/test-utils/interactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,8 @@ let focusableSelector = [
'iframe',
'input:not([disabled])',
'select:not([disabled])',
'details:not(:has(> summary))',
'details>summary',
'textarea:not([disabled])',
]
.map(
Expand Down
2 changes: 2 additions & 0 deletions packages/@headlessui-react/src/utils/focus-management.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ export let focusableSelector = [
'iframe',
'input:not([disabled])',
'select:not([disabled])',
'details:not(:has(> summary))',
'details>summary',
'textarea:not([disabled])',
]
.map(
Expand Down
2 changes: 2 additions & 0 deletions packages/@headlessui-vue/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix restoring focus to correct element when closing `Dialog` component ([#3365](https://github.com/tailwindlabs/headlessui/pull/3365))
- Cleanup `process` in Combobox component when using virtualization ([#3495](https://github.com/tailwindlabs/headlessui/pull/3495))
- Ensure outside click properly works when clicking SVG elements ([#3777](https://github.com/tailwindlabs/headlessui/pull/3777))
- Support `<details>` as a focusable element without `<summary>` ([#3389](https://github.com/tailwindlabs/headlessui/pull/3389))
- Support `<summary>` as a focusable element inside `<details>` ([#3389](https://github.com/tailwindlabs/headlessui/pull/3389))

## [1.7.22] - 2024-05-08

Expand Down
2 changes: 2 additions & 0 deletions packages/@headlessui-vue/src/test-utils/interactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,8 @@ let focusableSelector = [
'iframe',
'input:not([disabled])',
'select:not([disabled])',
'details:not(:has(> summary))',
'details>summary',
'textarea:not([disabled])',
]
.map(
Expand Down
2 changes: 2 additions & 0 deletions packages/@headlessui-vue/src/utils/focus-management.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ export let focusableSelector = [
'iframe',
'input:not([disabled])',
'select:not([disabled])',
'details:not(:has(> summary))',
'details>summary',
'textarea:not([disabled])',
]
.map(
Expand Down
Loading