-
Notifications
You must be signed in to change notification settings - Fork 60
schema: move 'concurrent schema update' error to constants #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bfd201c to
769e90a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to change the commit title too:
const: add 'concurrent schema update' error constant
Up to you.
Please, add a unit-test for the constant that checks that it value is "concurrent schema update". This test will help to fix this behavior (error string).
769e90a to
f17afe9
Compare
f17afe9 to
ed88a1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter is red.
5bc3968 to
5ddbf80
Compare
|
If we have an issue on GitHub, then it is a good idea to provide a link to it. In this case, a link to ticket in Jira is a good idea, but not required. -> or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fix the commit/PR message. See above.
Closes #404, TNTP-3336
5ddbf80 to
780841e
Compare
Closes #404, TNTP-3336