-
Notifications
You must be signed in to change notification settings - Fork 60
ci: update GitHub Actions workflows #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c79ed64
to
9f47ffd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch.
The main problem here is that the common code is incorrectly extracted. We need the reusable_testing.yml
file for integration tests launched from tarantool/tarantool
.
9293c92
to
21d59b6
Compare
a4ae7f0
to
42a3cbb
Compare
f279f50
to
5a08f52
Compare
`check.yaml`: * All jobs now run on ubuntu-latest instead of ubuntu-22.04. * Updated actions/checkout to v5, tarantool/setup-tarantool to v4, and actions/setup-go to v5. * Upgraded luacheck's Tarantool version to 3.4. `reusable-run.yml`: * Created a new reusable workflow to centralize testing logic, accepting os, tarantool-version, go-version, coveralls, and fuzzing as inputs. * Uses actions/checkout@v5 and actions/setup-go@v5. * Removed alternative cmake version. `reusable_testing.yml`: * Updated actions versions and version of tt. `testing.yml`: * Split run-tests-ce into run-tests-tarantool-1-10 (for Tarantool 1.10) and run-tests (for Tarantool 2.11, 3.4, and master). * Both new jobs leverage the reusable-run.yml workflow. * Updated actions/checkout to v5, actions/cache to v4, and actions/setup-go to v5. remove alternative cmake version
5a08f52
to
4cf88a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
check.yaml
:and actions/setup-go to v5.
reusable-run.yml
:os, tarantool-version, go-version, coveralls, and fuzzing as inputs.
reusable_testing.yml
:testing.yml
:and run-tests (for Tarantool 2.11, 3.4, and master).
to v5.