Skip to content

Conversation

bigbes
Copy link
Collaborator

@bigbes bigbes commented Sep 5, 2025

  • Update versions of actions/checkout to v5, tarantool/setup-tarantool to v4 and actions/setup-go to v5.
  • Use ubuntu-latest instead of ubuntu-22.04 if possible.

check.yaml:

  • All jobs now run on ubuntu-latest instead of ubuntu-22.04.
  • Updated actions/checkout to v5, tarantool/setup-tarantool to v4,
    and actions/setup-go to v5.
  • Upgraded luacheck's Tarantool version to 3.4.

reusable-run.yml:

  • Created a new reusable workflow to centralize testing logic, accepting
    os, tarantool-version, go-version, coveralls, and fuzzing as inputs.
  • Uses actions/checkout@v5 and actions/setup-go@v5.

reusable_testing.yml:

  • Updated actions versions and version of tt

testing.yml:

  • Split run-tests-ce into run-tests-tarantool-1-10 (for Tarantool 1.10)
    and run-tests (for Tarantool 2.11, 3.4, and master).
  • Both new jobs leverage the reusable-run.yml workflow.
  • Updated actions/checkout to v5, actions/cache to v4, and actions/setup-go
    to v5.

@bigbes bigbes force-pushed the bigbes/tntp-no-update-versions-in-ci branch 3 times, most recently from c79ed64 to 9f47ffd Compare September 5, 2025 18:25
@bigbes bigbes marked this pull request as ready for review September 5, 2025 19:01
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch.

The main problem here is that the common code is incorrectly extracted. We need the reusable_testing.yml file for integration tests launched from tarantool/tarantool.

@oleg-jukovec oleg-jukovec requested review from patapenka-alexey and removed request for dmyger September 8, 2025 07:24
@bigbes bigbes force-pushed the bigbes/tntp-no-update-versions-in-ci branch from 9293c92 to 21d59b6 Compare September 8, 2025 09:36
@bigbes bigbes requested a review from oleg-jukovec September 8, 2025 09:36
@bigbes bigbes force-pushed the bigbes/tntp-no-update-versions-in-ci branch 2 times, most recently from a4ae7f0 to 42a3cbb Compare September 8, 2025 10:18
@bigbes bigbes force-pushed the bigbes/tntp-no-update-versions-in-ci branch from f279f50 to 5a08f52 Compare September 8, 2025 11:33
`check.yaml`:
* All jobs now run on ubuntu-latest instead of ubuntu-22.04.
* Updated actions/checkout to v5, tarantool/setup-tarantool to v4,
  and actions/setup-go to v5.
* Upgraded luacheck's Tarantool version to 3.4.

`reusable-run.yml`:
* Created a new reusable workflow to centralize testing logic, accepting
  os, tarantool-version, go-version, coveralls, and fuzzing as inputs.
* Uses actions/checkout@v5 and actions/setup-go@v5.
* Removed alternative cmake version.

`reusable_testing.yml`:
* Updated actions versions and version of tt.

`testing.yml`:
* Split run-tests-ce into run-tests-tarantool-1-10 (for Tarantool 1.10)
  and run-tests (for Tarantool 2.11, 3.4, and master).
* Both new jobs leverage the reusable-run.yml workflow.
* Updated actions/checkout to v5, actions/cache to v4, and actions/setup-go
  to v5.

remove alternative cmake version
@bigbes bigbes force-pushed the bigbes/tntp-no-update-versions-in-ci branch from 5a08f52 to 4cf88a6 Compare September 8, 2025 11:49
Copy link

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleg-jukovec oleg-jukovec merged commit e50fbb5 into master Sep 8, 2025
38 of 39 checks passed
@oleg-jukovec oleg-jukovec deleted the bigbes/tntp-no-update-versions-in-ci branch September 8, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants