Deprecate use of imageset.sh #944
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there another tooling in place to replace this? Looks scary to drop everything if we don't have anything to replace it with at the moment |
|
Yes we should only land this once everything is working the new way. But the PR is prepared and ready to go when that is the case. I'll mark it as draft, to help avoid that we land it. Unfortunately "draft" makes it appear that it isn't ready for review, when it is. Really the state is "ready for review, but not ready to merge" but that isn't an option in the github interface. 😝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been agreed that images should be built by Release SRE moving forward, so I am deprecating the tooling here.
Note, this only removes the tooling, the original image definitions are preserved. I also deleted docker worker images, since they are no longer needed.