Skip to content

Conversation

@danfimov
Copy link

@danfimov danfimov commented Nov 17, 2025

Closes #6

Features:

  • Replaced poetry with uv
  • Dropped support for python 3.8/3.9 and added 3.13 to test suit

Fixes:

  • Removed unused parse_val function
  • Removed send_backoff_ms parameter from consumer (seems like it not exist in aiokafka 0.10.0+)

Mics:

  • Replaced all linters with ruff (as in main taskiq repo)
  • Replaced bitnami/kafka with apache/kafka (bacase bitnami no longer publish images) and created docker-compose for local development
  • Update actions in CI workflow
  • Deleted pytest.mark.anyio marks in favor of anyio_mode=auto config option.

Copilot AI review requested due to automatic review settings November 17, 2025 14:17
@danfimov danfimov force-pushed the replace-poetry-with-uv branch from 47055bf to 44aae14 Compare November 17, 2025 14:19
Copilot finished reviewing on behalf of danfimov November 17, 2025 14:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the project's build system and tooling by replacing Poetry with uv, dropping Python 3.8/3.9 support while adding Python 3.13, and consolidating linting tools under ruff. The changes include updating CI workflows, replacing bitnami/kafka with apache/kafka images, and removing deprecated code.

Key Changes:

  • Migrated from Poetry to uv for dependency management and building
  • Updated Python version support from 3.8-3.11 to 3.10-3.13
  • Consolidated multiple linters (flake8, isort, autoflake, wemake-python-styleguide) into ruff
  • Removed unused parse_val function and deprecated send_backoff_ms parameter
  • Updated CI workflows and switched to Apache Kafka images

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Converted from Poetry format to PEP 621 format with uv as build backend; updated dependencies and added ruff configuration
tests/test_broker.py Removed pytest.mark.anyio decorators and modernized type hints to use PEP 604 union syntax
tests/conftest.py Removed empty parentheses from fixture decorators and updated imports to use collections.abc
taskiq_aio_kafka/broker.py Removed unused parse_val function, modernized type hints, and simplified exception raising
taskiq_aio_kafka/models.py Removed deprecated send_backoff_ms parameter and modernized type hints
taskiq_aio_kafka/exceptions.py Added __template__ attribute for better error messaging
docker-compose.yaml Added new docker-compose file with Apache Kafka 4.1.1 configuration
README.md Fixed typo ("lirary" → "library") and added PyPI badges
LICENSE Updated copyright year to 2025
.pre-commit-config.yaml Updated hook versions and replaced linting tools with ruff
.github/workflows/test.yml Updated to use uv and Apache Kafka images with Python 3.10-3.13
.github/workflows/release.yml Updated to use uv and trusted publishing for releases
.flake8 Removed as flake8 is replaced by ruff
poetry.lock Removed as Poetry is replaced by uv

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danfimov danfimov force-pushed the replace-poetry-with-uv branch from 44aae14 to 40d5bb3 Compare November 17, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Python 3.13 -> aiokafka 0.12.0

1 participant