Replace < with <= in NonISODateAdd around month boundaries #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 24, 2025
Uplifts unicode-org/icu4x#7257 Caused by spec bug: tc39/proposal-intl-era-monthcode#98 Change-Id: I5df814a7ef7c2c8b1e44affd34fd31d017c04b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201147 Auto-Submit: Manish Goregaokar <[email protected]> Reviewed-by: Łukasz Anforowicz <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1549444}
sffc
approved these changes
Nov 25, 2025
Collaborator
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
I recall thinking that this condition didn't matter for < vs <= because the resulting day is the same either way, but then I think the overflow reject got grafted in a bit later and made it matter whether < or <= is used. Thanks for the catch
Manishearth
added a commit
to unicode-org/icu4x
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endOfMonth.Day is a valid day value, we should not be erroring for it.