Calendar reference code stuff #3145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error messages are not defined in the spec text, but should not cause observable effects.
See https://tc39.es/proposal-intl-era-monthcode/#sup-availablecalendars These IDs correspond to calendars that in practice are not being used in real life, and have already been removed in Firefox.
The era/monthCode proposal went through some changes in the era codes in the past while. Update the calendar definitions to reflect these changes. This allows removing makeHelperGregorianFixedEpoch, as there are now no longer any solar calendars without eras. We can also move completeEraYear into the nonISOBaseHelper's adjustCalendarDate method, since the only calendars without eras are now lunisolar calendars that have to override adjustCalendarDate anyway.
This is needed for dealing with the coptic era that proposal-intl-era-monthcode drops, but is still present in old versions of ICU as ERA0. We give it a Symbol era code so that it can never be matched by user code.
…c IDs The calendar IDs 'islamic' and 'islamic-rgsa' don't actually correspond to calendars in use and don't specify a calendar algorithm. The era- monthCode proposal makes implementations define fallback behaviour for them. If the JS engine already performs the fallback behaviour, this code should have no effect.
There is another comment not too far below this one that says basically the same thing.
The calendar impl object doesn't have an `id` property, only the helper object does.
This makes the reference implementation slightly more like the spec text, which should help make sure the spec text is correct. More commits like this to follow.
To eventually break the circular dependency between calendar.mjs and ecmascript.mjs, we will need to stop accessing the ES object in the latter file. Since we already import Call directly from es-abstract, this is a trivial step down that path.
This makes the reference implementation slightly more like the spec text, which should help make sure the spec text is correct.
This makes the reference implementation slightly more like the spec text, which should help make sure the spec text is correct. The derivation of monthsPerYear from the table for non-lunisolar calendars would ideally be written differently, but this is temporary until we can refactor the implementation to be even more like the spec.
Adding days to an ISO date does not have any calendar-specific behaviour so extract it out of the calendar helper objects. There were also some calls with a leftover cache parameter which was unused.
ptomato
force-pushed
the
calendar-stuff
branch
from
7b558e9 to
6d50b46
Compare
This folder has been removed from test262 and the tests moved into intl402/DateTimeFormat. Now that we've updated test262 past that point, we don't need this line anymore.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3145 +/- ##
==========================================
+ Coverage 96.82% 96.86% +0.03%
==========================================
Files 22 22
Lines 9995 10081 +86
Branches 1819 1824 +5
==========================================
+ Hits 9678 9765 +87
+ Misses 270 267 -3
- Partials 47 49 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sffc
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/calendar.mjslib/calendar.mjsto make the calculations work more like the spec text of the Intl Era Monthcode proposal, e.g., in terms of abstract ops such as CalendarSupportsEra and IsValidMonthCodeForCalendar (I didn't refactor everything though; this PR just contains the easy parts)Best reviewed commit by commit.