Skip to content

Add a test for importing a module part of a SCC with an errored component on the right #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a test for importing a module part of a SCC with an errored component on the right #4502

wants to merge 1 commit into from

Conversation

nicolo-ribaudo
Copy link
Member

This test was suggested by @guybedford today in the modules harmony call.

@gibson042 normally I would ask for a review to my colleagues, but given that you were in the call and we talked about this together I nominate you :P

@nicolo-ribaudo nicolo-ribaudo requested a review from a team as a code owner May 22, 2025 17:45
@nicolo-ribaudo
Copy link
Member Author

Uhm the tests are failing with

FAIL test/language/module-code/scc-with-errored-right-component-sync-evaluation.js (default)
  asyncTest called without async flag

FAIL test/language/module-code/scc-with-errored-right-component-sync-evaluation.js (strict mode)
  asyncTest called without async flag

Which is the same error I get in #4500, but I don't understand why.

@gibson042 gibson042 self-assigned this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gibson042 gibson042

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolo-ribaudo @ptomato @gibson042