Add test case when countBytes in TA.p.slice is set to zero #4537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This case isn't covered by existing tests. |
gibson042
previously requested changes
Jul 16, 2025
test/built-ins/TypedArray/prototype/slice/resize-count-bytes-to-zero.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/slice/resize-count-bytes-to-zero.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/slice/resize-count-bytes-to-zero.js
Outdated
Show resolved
Hide resolved
|
@anba would you mind addressing the comments above? |
anba
force-pushed
the
slice-count-zero
branch
2 times, most recently
from
779fd9d to
2dc86bc
Compare
`countBytes` can be set to zero in step 14.d when resizable array buffers are used.
Ms2ger
force-pushed
the
slice-count-zero
branch
from
2dc86bc to
83c1947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
countBytescan be set to zero in step 14.d when resizable array buffers are used.