Temporal: Add tests for observable order of options get and cast #4557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Aug 21, 2025
...-ins/Temporal/PlainDateTime/prototype/toString/options-read-before-algorithmic-validation.js
Outdated
Show resolved
Hide resolved
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Aug 21, 2025
This updates to the non-observable changes from tc39/proposal-temporal#3135 This also makes the changes from to-be-merged spec PR tc39/proposal-temporal#3130 (these changes are observable) This passes the tests added in tc39/test262#4557. Bug: 401065166 Change-Id: I6a6a6964a2436085a3fa20b3bbb10392f0fe95df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6851756 Auto-Submit: Manish Goregaokar <[email protected]> Commit-Queue: Manish Goregaokar <[email protected]> Reviewed-by: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/heads/main@{#101978}
These tests cover the normative change approved in the July 2025 TC39 plenary. See tc39/proposal-temporal#3130. All properties of user-passed options objects should be read and cast before any "algorithmic validation" is done. This is a lot of tests, that cover every entry point where an options object is passed in, where subsequently an exception can be thrown or user code can be called. However, the normative change only affects 10 of these tests: - Instant.p.since,until,toString - PlainDate.p.since,until - PlainTime.p.since,until - PlainYearMonth.p.since,until - ZonedDateTime.p.toString The other 35 tests simply close a gap in coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests cover the normative change approved in the July 2025 TC39 plenary. See tc39/proposal-temporal#3130. All properties of user-passed options objects should be read and cast before any "algorithmic validation" is done.
This is a lot of tests, that cover every entry point where an options object is passed in, where subsequently an exception can be thrown or user code can be called.
However, the normative change only affects 10 of these tests:
The other 35 tests simply close a gap in coverage.