kludge up for Eglot's use of codeAction/resolve #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obviously a hack but it works for my use case, which is the usual "need to use (based)Pyright & Ruff with Eglot".
Prior to this change, Ruff's code actions (at least visible ones, like organizing imports) did not work with Eglot because Eglot invokes such actions through
codeAction/resolveonly and since Ruff is normally not the promary LSP server its declaration of support forcodeAction/resolvewas not propagated by the proxy.My main problem with all this is that I have no idea why
codeAction/resolveeven exists or what exactly it's supposed to do (and I am furthermore unable to understand the relevant part of the spec), so the approach here, while fixing my immediate problem, is most likely wrong in general.And it probably would be inadequate in case of several proxied servers with resolve support.
But posting in case anyone finds this useful.