Changed "Lock" to "Close" to reduce user confusion. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm going to hold off on this PR until it actually causes issues. Especially because there is no nice close emoji. |
Contributor
|
Pending discussion, this PR is not yet closed. |
Contributor
|
If #40 goes in this PR will be closed, else this one will be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed "Lock" to "Close the" in the Options Menu.
Changed from "Lock" to "Close" for functions and variables to reduce confusion for future developers.
Kept the ":lock:" emoji to symbolize to the public that the poll is closed.
Side Note: Took a poll of a random non technical group to find out whether "Close" or "End" would be a better word. Results can be found below:
