Skip to content

Conversation

@dessyordanova
Copy link
Collaborator

Report Templates in Web Report Designer: https://github.com/telerik/reporting/issues/5464

@dessyordanova
Copy link
Collaborator Author

To all reviewers: Do we need a workflow diagram explaining the process for editing an existing template, considering the fact we have a dedicated tutorial how to do it?

Copy link

@kachamachkov kachamachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great layout and work Desi, thank you! There are a few typos that I managed to find, please fix them. Additionally, if you like some of my refactoring suggestions, consider applying them.

Copy link
Contributor

@yordan-mitev yordan-mitev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several comments directed at concerns related to the organization and logic of the article. I'm not commenting on any surface-level issues like tone of voice and style as I believe they must be handled after sorting out the structural matter.

@dessyordanova
Copy link
Collaborator Author

@yordan-mitev, could you please review the final version of the PR?

mzanev
mzanev previously approved these changes Nov 5, 2025
Copy link
Contributor

@mzanev mzanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The articles look great!

Copy link
Contributor

@yordan-mitev yordan-mitev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final style-related comments

@dessyordanova
Copy link
Collaborator Author

Ready to ship for Q4 2025

@dessyordanova dessyordanova dismissed kachamachkov’s stale review November 10, 2025 06:20

Your feedback was mostly addressed. A lot of other changes and refactoring were made, synced with Dancho. Dismissing the requested changes since it blocks the PR from being merged.

Copy link
Contributor

@dnikolov-prg dnikolov-prg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dnikolov-prg dnikolov-prg merged commit e63e569 into master Nov 10, 2025
@dnikolov-prg dnikolov-prg deleted the dess-wrd-templates branch November 10, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants