-
Notifications
You must be signed in to change notification settings - Fork 29
Dess wrd templates #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dess wrd templates #1870
Conversation
|
To all reviewers: Do we need a workflow diagram explaining the process for editing an existing template, considering the fact we have a dedicated tutorial how to do it? |
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
kachamachkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great layout and work Desi, thank you! There are a few typos that I managed to find, please fix them. Additionally, if you like some of my refactoring suggestions, consider applying them.
yordan-mitev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left several comments directed at concerns related to the organization and logic of the article. I'm not commenting on any surface-level issues like tone of voice and style as I believe they must be handled after sorting out the structural matter.
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/report-templates.md
Outdated
Show resolved
Hide resolved
|
I have applied most of the recommendations and split the main article into two - one for end-users and one for developers as Dancho suggested: |
|
@yordan-mitev, could you please review the final version of the PR? |
|
@kachamachkov could you please check whether the requested changes are still necessary after the refactoring? https://github.com/telerik/reporting-docs/blob/dess-wrd-templates/user-guide/report-templates.md |
mzanev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The articles look great!
yordan-mitev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final style-related comments
designing-reports/report-designer-tools/web-report-designer/configuring-report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/configuring-report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/configuring-report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/configuring-report-templates.md
Outdated
Show resolved
Hide resolved
designing-reports/report-designer-tools/web-report-designer/configuring-report-templates.md
Outdated
Show resolved
Hide resolved
…nfiguring-report-templates.md Co-authored-by: Yordan <[email protected]>
…nfiguring-report-templates.md Co-authored-by: Yordan <[email protected]>
…nfiguring-report-templates.md Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
…nfiguring-report-templates.md Co-authored-by: Yordan <[email protected]>
…nfiguring-report-templates.md Co-authored-by: Yordan <[email protected]>
|
Ready to ship for Q4 2025 |
Your feedback was mostly addressed. A lot of other changes and refactoring were made, synced with Dancho. Dismissing the requested changes since it blocks the PR from being merged.
dnikolov-prg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Report Templates in Web Report Designer: https://github.com/telerik/reporting/issues/5464