Snips Files #76
Open
Snips Files #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
flossypurse
reviewed
May 22, 2024
Contributor
flossypurse
left a comment
flossypurse
left a comment
There was a problem hiding this comment.
Might need a detailed explanation of how this works. Looks like a lot of code has been moved around and it is hard to tell what logic is being introduced and/or changed.
Curious why SNIPFILE and SNIPFILEEND are needed as new target placeholders?
What would an example file origin config look like?
Comment on lines
+34
to
+43
| // Custom promisified version of eachLine | ||
| const eachLineAsync = (filePath, cb) => { | ||
| return new Promise((resolve, reject) => { | ||
| eachLine(filePath, cb, (err) => { | ||
| if (err) reject(err); | ||
| else resolve(); | ||
| }); | ||
| }); | ||
| }; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snipfile