Skip to content

Cleanup Go's Resource Based Auto Tuner code snippet #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Cleanup Go's Resource Based Auto Tuner code snippet #3540

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ce98be
add missing import for Go's auto tuner
kevinawoo Apr 18, 2025
4be570a
use exported defaults
kevinawoo Apr 18, 2025
b92d406
fix syntax typos
kevinawoo Apr 21, 2025
50264f7
Merge branch 'main' into kevinawoo-patch-1
kevinawoo Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions docs/develop/worker-performance.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,8 @@ These examples focus on Activities and Local Activities, since Workflow Tasks no
### Go SDK

```go
import "go.temporal.io/sdk/contrib/resourcetuner"

// Using the ResourceBasedTuner in worker options
tuner, err := resourcetuner.NewResourceBasedTuner(resourcetuner.ResourceBasedTunerOptions{
TargetMem: 0.8,
Expand All @@ -283,36 +285,37 @@ if err != nil {
return err
}
workerOptions := worker.Options{
Tuner: tuner
Tuner: tuner,
}
// Combining different types
options := DefaultResourceControllerOptions()

// Customize the tuner
options := resourcetuner.DefaultResourceControllerOptions()
options.MemTargetPercent = 0.8
options.CpuTargetPercent = 0.9
controller := NewResourceController(options)
controller := resourcetuner.NewResourceController(options)
wfSS, err := worker.NewFixedSizeSlotSupplier(10)
if err != nil {
return err
}
actSS := &ResourceBasedSlotSupplier{controller: controller,
options: defaultActivityResourceBasedSlotSupplierOptions()}
laSS := &ResourceBasedSlotSupplier{controller: controller,
options: defaultActivityResourceBasedSlotSupplierOptions()}

actSS, err := resourcetuner.NewResourceBasedSlotSupplier(controller, resourcetuner.DefaultActivityResourceBasedSlotSupplierOptions())
laSS, err := resourcetuner.NewResourceBasedSlotSupplier(controller, resourcetuner.DefaultActivityResourceBasedSlotSupplierOptions())
nexusSS, err := worker.NewFixedSizeSlotSupplier(10)
if err != nil {
return err
}

compositeTuner, err := worker.NewCompositeTuner(worker.CompositeTunerOptions{
WorkflowSlotSupplier: wfSS,
ActivitySlotSupplier: actSS,
LocalActivitySlotSupplier: laSS,
NexusSlotSupplier: nexusSS,
WorkflowSlotSupplier: wfSS,
ActivitySlotSupplier: actSS,
LocalActivitySlotSupplier: laSS,
NexusSlotSupplier: nexusSS,
})
if err != nil {
return err
}
workerOptions := worker.Options{
Tuner: compositeTuner
Tuner: compositeTuner,
}
```

Expand Down