Skip to content

Properly skip infrequent polling test on time-skipping server #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Properly skip infrequent polling test on time-skipping server #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/polling/infrequent/workflow_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


async def test_infrequent_polling_workflow(client: Client, env: WorkflowEnvironment):
if not env.supports_time_skipping:
if env.supports_time_skipping:
pytest.skip("Too slow to test with time-skipping disabled")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boolean condition and the message don't seem to jointly make sense any longer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm, maybe I misunderstood the situation here and we are wanting to only run this test with time skipping and it's still too slow even with time skipping. Will look.


# Start a worker that hosts the workflow and activity implementations.
Expand Down
Loading