update samples to use environment configuration for client #233
+519
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THardy98
force-pushed
the
update_samples_env_config
branch
3 times, most recently
from
a92c84f to
df18612
Compare
cretz
reviewed
Aug 12, 2025
activity_worker/activity_worker.py
Outdated
| config = ClientConfig.load_client_connect_config( | ||
| config_file=str(get_temporal_config_path()) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Pedantic, but probably don't need this blank line in every sample
THardy98
force-pushed
the
update_samples_env_config
branch
from
a3daf44 to
136e3fc
Compare
THardy98
force-pushed
the
update_samples_env_config
branch
from
d9c0f98 to
fd5b254
Compare
cretz
reviewed
Aug 28, 2025
There was a problem hiding this comment.
Looks great to me. Holding off approving for same reason as at temporalio/samples-go#421 (review), not sure we want to tell everyone in all samples to use this yet. But an equivalent of temporalio/samples-go#420 that has advanced env config + just updating one may make sense for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Update samples to use environment configuration for clients.
Why?
Client environment configuration is intended as the preferred way to configure clients going forward.
Closes [Feature Request] Environment configuration #178
How was this tested:
Existing tests.
Any docs updates needed?
No