Skip to content

Delete references to never-constructed UpdateRejected event #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Delete references to never-constructed UpdateRejected event #2295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion temporal-sdk/src/main/java/io/temporal/internal/common/WorkflowExecutionUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ public static boolean isCommandEvent(HistoryEvent event) {
case EVENT_TYPE_SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_INITIATED:
case EVENT_TYPE_UPSERT_WORKFLOW_SEARCH_ATTRIBUTES:
case EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_ACCEPTED:
case EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_REJECTED:
case EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_COMPLETED:
case EVENT_TYPE_WORKFLOW_PROPERTIES_MODIFIED:
case EVENT_TYPE_NEXUS_OPERATION_SCHEDULED:
Expand Down
8 changes: 0 additions & 8 deletions temporal-sdk/src/main/java/io/temporal/internal/statemachines/WorkflowStateMachines.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,14 +1144,6 @@ private void validateCommand(Command command, HistoryEvent event) {
true,
commandAttributes.getMessageId().endsWith("accept"));
break;
case EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_REJECTED:
assertMatch(
command,
event,
"messageType",
true,
commandAttributes.getMessageId().endsWith("reject"));
break;
case EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_COMPLETED:
assertMatch(
command,
Expand Down
Loading