feat: push to ghcr #2063
Merged
feat: push to ghcr #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kemingy
commented
Nov 11, 2025
kemingy
commented
- part of feat: adopt ghcr #1959
- push envd & envd-sshd to both docker hub & ghcr
- push envd-daemonless & envd-python-cache to ghcr instead of docker hub
- change the release artifacts naming template
- fix envd-daemonless build platform target name
Signed-off-by: Keming <[email protected]>
kemingy
commented
Nov 11, 2025
Comment on lines
-50
to
-54
| {{ .Binary }}_{{ .Version }}_ | ||
| {{- title .Os }}_ | ||
| {{- if eq .Arch "amd64" }}x86_64 | ||
| {{- else if eq .Arch "386" }}i386 | ||
| {{- else }}{{ .Arch }}{{ end }} |
Member
Author
There was a problem hiding this comment.
I have no idea why the OS name should be capitalized here.
Arch names should be aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.