-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix rlds episode_metadata
#11096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix rlds episode_metadata
#11096
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@Tavish9 thank for the PR! IIUC, this changes the dataset info, so you need to change the example generation as well, see the failed tests. |
@fineguy already fix |
@Tavish9 please fix the failed tests. |
I also updated the logic of |
@Tavish9 please confirm locally that tests run successfully, this will be easier for the review. |
@fineguy sorry for bothering you. I don't find any steps for local testing in README. Could you please show me the way? |
@Tavish9 check this documentation: https://www.tensorflow.org/datasets/contribute#add_and_run_unittests |
@fineguy take a look, please |
This PR fixes rlds's
build_info
whenepisode_metadata
is not NoneReproduce
Currently, the returned features will get rid of
episode_metadata
key, which is not consistent with widely used rlds dataset:official tensorflow datasets robotics