Embedding Projector: fix t-SNE control when switching projections #6287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicialics
changed the title
rename params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
If projection is switched from t-SNE to UMAP, t-SNE doesn't pause and the framerate would crash (5fps on M1 pro)
If projection is switched from t-SNE to PCA/Custom, t-SNE is stopped, so user has to restart t-SNE when switching back.
Technical description of changes
Pause t-SNE when switching away, resume t-SNE when
Screenshots of UI changes
N/A
Detailed steps to verify changes work correctly (as executed by you)
toggle from t-SNE to any other panel and back to t-SNE will resume t-SNE immediately
Alternate designs / implementations considered