Skip to content

docs: Exclude local zones from aws_availability_zones data source in examples when retrieving list of available zones #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryantbiggs merged 11 commits into from
Dec 13, 2025
Merged

docs: Exclude local zones from aws_availability_zones data source in examples when retrieving list of available zones #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
40b8d19
Add ALB endpoint to outputs - this makes it easier to test for succes…
Feb 11, 2025
c9c01b9
fix trailing whitespace
Feb 11, 2025
bbd7ae2
update README to conform with conventions
Feb 11, 2025
9fc0127
Add ALB endpoint to outputs - this makes it easier to test for succes…
Feb 12, 2025
3dfd858
EOF fix
Feb 12, 2025
397946f
updates in response to bryantbiggs review
Mar 7, 2025
fce632b
docs updates to go with CR feedback
Mar 7, 2025
c265d51
merge from upstream
Dec 12, 2025
ac1f5da
prevent ecs az placement from using local-zones
Dec 12, 2025
234fdcd
add fix to all examples - prevent ecs az placement from using local-z…
Dec 13, 2025
9fcae72
fix region
Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ provider "aws" {
region = local.region
}

data "aws_availability_zones" "available" {}
data "aws_availability_zones" "available" {
# Exclude local zones
filter {
Copy link
Member

@bryantbiggs bryantbiggs Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a note so folks know why we do this https://github.com/terraform-aws-modules/terraform-aws-eks/blob/c41b58277ab3951eca8d11863edf178135ec7654/examples/eks-auto-mode/main.tf#L6

name = "opt-in-status"
values = ["opt-in-not-required"]
}
}

locals {
region = "eu-west-1"
Expand Down
8 changes: 7 additions & 1 deletion examples/ec2-autoscaling/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ provider "aws" {
region = local.region
}

data "aws_availability_zones" "available" {}
data "aws_availability_zones" "available" {
# Exclude local zones
filter {
name = "opt-in-status"
values = ["opt-in-not-required"]
}
}

locals {
region = "eu-west-1"
Expand Down
8 changes: 7 additions & 1 deletion examples/fargate/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ provider "aws" {
region = local.region
}

data "aws_availability_zones" "available" {}
data "aws_availability_zones" "available" {
# Exclude local zones
filter {
name = "opt-in-status"
values = ["opt-in-not-required"]
}
}

locals {
region = "eu-west-1"
Expand Down