feat: Add skip_destroy argument in the aws_s3_bucket_public_access_bl… #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paikend
reviewed
Aug 22, 2025
main.tf
Outdated
| @@ -1148,6 +1148,7 @@ resource "aws_s3_bucket_public_access_block" "this" { | |||
| block_public_policy = var.block_public_policy | |||
| ignore_public_acls = var.ignore_public_acls | |||
| restrict_public_buckets = var.restrict_public_buckets | |||
| skip_destroy = true | |||
There was a problem hiding this comment.
Replace the hardcoded value with a variable
Suggested change
| skip_destroy = true | |
| skip_destroy = var.skip_destroy |
Add variable declaration in variables.tf
Finally use command "pre-commit run -a" check README.md
There was a problem hiding this comment.
Made an update in accordance with your suggestions.
Thanks for the review ;)
There was a problem hiding this comment.
May I get your approval in here? @paikend
…ock and set it to true by default
antonbabenko
requested changes
Aug 25, 2025
|
@antonbabenko can I get your approval? I believe CI have passed now :) |
Almost. Please fix it. |
Update main.tf
I believe it's now finally done |
antonbabenko
approved these changes
Aug 25, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Aug 25, 2025
## [5.6.0](v5.5.0...v5.6.0) (2025-08-25) ### Features * Add skip_destroy argument in the aws_s3_bucket_public_access_bl… ([#352](#352)) ([8833269](8833269))
|
This PR is included in version 5.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ock and set it to true
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request