Skip to content

Conversation

@davide-zanon
Copy link
Contributor

@davide-zanon davide-zanon commented Oct 30, 2025

Description

This pull request creates a method to disallow users from using the alpha API for Compute Engine.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

This pull request creates a method to disallow users from using the alpha API for Compute Engine.
@davide-zanon davide-zanon requested review from a team as code owners October 30, 2025 16:36
@snippet-bot
Copy link

snippet-bot bot commented Oct 30, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Fixed the region tag.
@hp1100
Copy link

hp1100 commented Oct 30, 2025

LGTM

@davide-zanon
Copy link
Contributor Author

As in a similar pull request, users might encounter issues due to an organisation policy preventing the CI project from disabling preview features. This is an expected behaviour, and we can therefore disable tests.

For context, see #906 (comment).

@glasnt glasnt changed the title Create main.tf feat(compute): add preview disable feature Nov 4, 2025
@glasnt
Copy link
Contributor

glasnt commented Nov 4, 2025

Let's first try /gcbrun to confirm it's a CI issue before adding the testskip

@glasnt
Copy link
Contributor

glasnt commented Nov 4, 2025

/gcbrun

Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't require a skip tests, so I won't add it.

@glasnt glasnt merged commit 9856e2a into terraform-google-modules:main Nov 4, 2025
4 checks passed
@davide-zanon davide-zanon deleted the patch-8 branch November 4, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants