-
Notifications
You must be signed in to change notification settings - Fork 286
feat(compute): add preview disable feature #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request creates a method to disallow users from using the alpha API for Compute Engine.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Fixed the region tag.
|
LGTM |
|
As in a similar pull request, users might encounter issues due to an organisation policy preventing the CI project from disabling preview features. This is an expected behaviour, and we can therefore disable tests. For context, see #906 (comment). |
|
Let's first try /gcbrun to confirm it's a CI issue before adding the testskip |
|
/gcbrun |
glasnt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't require a skip tests, so I won't add it.
Description
This pull request creates a method to disallow users from using the alpha API for Compute Engine.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/compute/docs/reference/rest/alpha
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review