Proposed small UI improvement in driver selection panel #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I propose a small visual change that improves the UX by indicating which of the available methods is currently selected using the status icon of the actual method itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a small visual change that I believe improves the UI/UX.
At present, all available methods share the same icon (green circle). My PR changes this behavior by making the selected method use a different icon (green alt check box). This change improves the informational value of this UI element as it allows users to visually assess two things at once: (1) what methods are available and (2) which method has been selected, without having to refer back to the dropdown menu above.
On the example of the
memcachedmethod:P.S. Speaking about the UI of this block in general, the dropdown is not strictly necessary. The list below it is a bona fide single-choice selection element. I can look into reworking the whole component so that the the dropdown is ditched entirely, and the
driver-status-boxcontainer becomes clickable like a proper single-choice selector element.However this requires more work, and I need to make sure my time on this will not be wasted. This PR serves to check if plugin developer @terrylinooo is on board with my thoughts on the subject.