feat(redpanda): add support for http proxy #3258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
simon0191
changed the title
stevenh
reviewed
Aug 12, 2025
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Looks good, just one question.
Member
|
I'm on PTO but checking GH from time to time: let's not forget adding the new options to the docs 🙏 |
Contributor
Author
@mdelapenya done ✍️ |
mdelapenya
reviewed
Aug 25, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
Hi @simon0191, thanks for your contribution. I left a few comments regarding simplifying how the new auth methods are configured.
Other than that, the overall idea resonates to me, so I think that, if we move forward with the proposed changes, we can merge this into the project.
Please let me know what you think about that?
simon0191
force-pushed
the
redpanda-add-support-for-http-proxy
branch
from
d5864d6 to
c025872
Compare
Contributor
Author
|
@mdelapenya thanks for the review! all comments addressed |
mdelapenya
reviewed
Sep 15, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM!, just added a few comments regarding using the new type instead of plain strings. Other than that, great job with the PR!
simon0191
force-pushed
the
redpanda-add-support-for-http-proxy
branch
from
e33e3f0 to
7555a0d
Compare
Contributor
Author
Thanks @mdelapenya. Comments addressed |
mdelapenya
reviewed
Sep 15, 2025
simon0191
force-pushed
the
redpanda-add-support-for-http-proxy
branch
from
196532b to
c45f312
Compare
mdelapenya
added
the
feature
mdelapenya
approved these changes
Sep 15, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks for following us during the review. Great addition to the Redpanda module 🚀
mdelapenya
added a commit
that referenced
this pull request
Sep 15, 2025
* main: (24 commits) chore(deps): bump golang.org/x/sys from 0.32.0 to 0.36.0 (#3282) feat(redpanda): add support for http proxy (#3258) chore(deps): bump github/codeql-action from 3.29.3 to 3.30.3 (#3287) chore(go): bump to Go 1.24 as minimal version (#3298) deps(mongodb): update MongoDB Go Driver to v2 (#3278) chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.5 to 4.25.6 (#3224) chore(deps): bump mkdocs-include-markdown-plugin from 7.1.6 to 7.1.7 (#3284) docs: clarify no client SDKs in production modules/images, in contributing.md (#3279) chore(deps): bump github.com/docker/go-connections from 0.5.0 to 0.6.0 (#3285) chore(deps): bump tj-actions/changed-files from 46.0.3 to 47.0.0 (#3283) chore(modulegen): detect missing project files after new module creation (#3281) chore(deps): bump github.com/docker/docker in /modules/nebulagraph (#3277) feat(nebulagraph): add NebulaGraph module (#3266) fix: preserve unix socket schema in testcontainers host from properties (#3213) feat(registry): add helper functions to pull and tag images (#3275) fix(reaper): remove termSignal override (#3261) chore(deps): bump ryuk to v0.13.0, which uses scratch as base image (#3274) chore(release): refine release script to update inter-module dependencies (#3273) fix(registry): update `WithHtpasswd` to use `os.CreateTemp` instead of `os.Create` with `filepath.Join`. (#3272) chore(deps): bump github.com/docker/docker from 28.2.2+incompatible to 28.3.3+incompatible (#3270) ...
mdelapenya
added a commit
to prestonvasquez/testcontainers-go
that referenced
this pull request
Sep 17, 2025
* main: (22 commits) chore(deps): bump golang.org/x/net from 0.28.0 to 0.38.0 (testcontainers#3299) feat: allow saving specific platforms for an image (testcontainers#3218) chore(deps): bump dario.cat/mergo from 1.0.1 to 1.0.2 (testcontainers#3238) chore(deps): bump golang.org/x/sys from 0.32.0 to 0.36.0 (testcontainers#3282) feat(redpanda): add support for http proxy (testcontainers#3258) chore(deps): bump github/codeql-action from 3.29.3 to 3.30.3 (testcontainers#3287) chore(go): bump to Go 1.24 as minimal version (testcontainers#3298) deps(mongodb): update MongoDB Go Driver to v2 (testcontainers#3278) chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.5 to 4.25.6 (testcontainers#3224) chore(deps): bump mkdocs-include-markdown-plugin from 7.1.6 to 7.1.7 (testcontainers#3284) docs: clarify no client SDKs in production modules/images, in contributing.md (testcontainers#3279) chore(deps): bump github.com/docker/go-connections from 0.5.0 to 0.6.0 (testcontainers#3285) chore(deps): bump tj-actions/changed-files from 46.0.3 to 47.0.0 (testcontainers#3283) chore(modulegen): detect missing project files after new module creation (testcontainers#3281) chore(deps): bump github.com/docker/docker in /modules/nebulagraph (testcontainers#3277) feat(nebulagraph): add NebulaGraph module (testcontainers#3266) fix: preserve unix socket schema in testcontainers host from properties (testcontainers#3213) feat(registry): add helper functions to pull and tag images (testcontainers#3275) fix(reaper): remove termSignal override (testcontainers#3261) chore(deps): bump ryuk to v0.13.0, which uses scratch as base image (testcontainers#3274) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
So users can use Redpanda HTTP Proxy
Related issues
How to test this PR
Run
cd modules/redpanda && go test -v -run TestRedpandaHTTPProxy -timeout 3m