-
Notifications
You must be signed in to change notification settings - Fork 162
perf: replace ulid
with ferroid
's ULID for better performance
#829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ulid
with ferroid
's ULID for better performanceulid
with ferroid
's ULID for better performance
ulid
with ferroid
's ULID for better performanceulid
with ferroid
's ULID for better performance
Thank you for the contribution! I generally would be happy to accept more performant & modern version But just to understand - are there any benchmarks to compare I also see some deviations from ULID spec are mentioned in the readme. Based on the description it looks safe enough (at quick glance) and there shouldn't be overflow bugs, but probably it's a sign of including this change into the next major release, not minor/patch. |
Full disclosure, I'm the author of
Here's some benchmarks:
Both
|
Replaces the ulid crate with ferroid, a drop-in alternative with identical behavior in this context, but better performance for encode/decode.
Also saves an allocation (not that it is critical here).
There's no functional difference here, but
ferroid
provides a more modern foundation for ULID.