Skip to content

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Sep 3, 2025

What:

Update action versions:

From To runs.using
actions/checkout@v2 actions/checkout@v5 node24
actions/setup-node@v2 actions/setup-node@v4 node20
codecov/codecov-action@v1 codecov/codecov-action@v5 composite
cycjimmy/semantic-release-action@v2 cycjimmy/semantic-release-action@v5 node24

and called dependency:

From To
semantic-release@17 semantic-release@24

Update from Node.js 20 (Maintenance LTS) to Node.js 22 (Active LTS)

Why:


The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/


[@octokit/request] "GET https://api.github.com/search/issues?q=repo%3Atesting-library%2Fcypress-testing-library+type%3Apr+is%3Amerged+e6ac1355982eb46508da4e2954213b7d274475a3" is deprecated. It is scheduled to be removed on Thu, 04 Sep 2025 00:00:00 GMT. See https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/

How:

Change the action versions defined in .github/workflows/validate.yml

Checklist:

  • Documentation N/A

  • Tests

  • Ready to be merged

  • Note that no coverage report is found. This is the same as before this PR and is an issue that would need to be investigated separately.

  • Otherwise, I've tested this branch standalone as far as I can, also using semantic-release dry-run.

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Sep 3, 2025

@kentcdodds

Many thanks for merging the Cypress 15 PR (#282)! You wrote:

I'm not really a maintainer anymore, but since it doesn't seem like there's anyone else I'll go ahead and merge this since it's pretty straightforward.

Does this mean that there is no maintainer for this repo these days? I went ahead and updated the CI workflow versions in this PR after I noticed that there were deprecation warnings in the logs, so hopefully either you or somebody else will be able to review and merge this PR?!

Edit:

I overlooked that there is a long list of maintainers for this repo in the npm registry, so perhaps this list should be separately reviewed so that it only contains users who are active maintainers?:

$ npm view @testing-library/cypress maintainers
[
  'testing-library-bot <[email protected]>',
  'kentcdodds <[email protected]>',
  'timdeschryver <[email protected]>',
  'patrickhulce <[email protected]>',
  'dfcook <[email protected]>',
  'gpx <[email protected]>',
  'mpeyper <[email protected]>',
  'mihar-22 <[email protected]>',
  'pago <[email protected]>',
  'cmckinstry <[email protected]>',
  'thymikee <[email protected]>',
  'brrianalexis <[email protected]>',
  'jdecroock <[email protected]>',
  'mdjastrzebski <[email protected]>',
  'eps1lon <[email protected]>',
  'phryneas <[email protected]>'
]

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there's no active maintainer. Cypress should follow playwright's example and build these queries in as an official part of their API.

@MikeMcC399
Copy link
Contributor Author

@kentcdodds

Yeah, there's no active maintainer. Cypress should follow playwright's example and build these queries in as an official part of their API.

I've passed your comment on, in a request to the Cypress.io team in cypress-io/cypress#32414

@kentcdodds kentcdodds merged commit 1c4813c into testing-library:main Sep 3, 2025
4 checks passed
@MikeMcC399 MikeMcC399 deleted the update/validate-versions branch September 3, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated action versions in validate workflow
2 participants