-
Notifications
You must be signed in to change notification settings - Fork 6
Community wallets modules page #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
23b37c1 to
f1d2528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file from PR please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file from PR please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file from PR please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file from PR please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file from PR please
| {% step %} | ||
|
|
||
| ### Add docs | ||
| - Write a `README.md` (what it is, install, config, usage, API, feature table) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can create a template README that just needs replacements? READMEs in all wallet modules should be very similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates on this?
| {% endstepper %} | ||
| --- | ||
|
|
||
| ## Official Inclusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to the folder README, so it can be linked from different guides
SUMMARY.md
Outdated
| * [Configuration](sdk/lending-modules/lending-aave-evm/configuration.md) | ||
| * [API Reference](sdk/lending-modules/lending-aave-evm/api-reference.md) | ||
|
|
||
| * [New Protocol Modules](sdk/protocol-new-modules/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this from here, broken links
SUMMARY.md
Outdated
|
|
||
| ## Community Modules | ||
|
|
||
| * [Community Modules](community-modules/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page can be under "Resources" group
SUMMARY.md
Outdated
| * [Price Rates](tools/price-rates/README.md) | ||
| * [Configuration](tools/price-rates/configuration.md) | ||
| * [API Reference](tools/price-rates/api-reference.md) | ||
| * [WDK Modules Template](tools/wdk-modules-template/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be under "Resources" group.
Name should be "Create custom SDK modules"
| │ └─ index.d.ts | ||
| ├─ src/ | ||
| │ ├─ manager.js | ||
| │ ├─ account-read-only.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not match the actual repo structure
| Open the folder called `wdk-wallet-template`, which contains the scaffolding for a wallet module | ||
|
|
||
| ```text | ||
| wallet-<example>/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is not correct compared to the actual repo
| {% step %} | ||
| ### Implement Account Logic | ||
|
|
||
| - Implement the required methods you find in `account-read-only.js` (read-only) and `account.js` (full account). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files don't exist in actual repo
| {% step %} | ||
|
|
||
| ### Add docs | ||
| - Write a `README.md` (what it is, install, config, usage, API, feature table) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates on this?
Included 2 folder and 3 new pages:
tools: Included
wdk-modules-templatefolder withcommunity-modules
Addind guidence for community to create new modules compatible with WDK ecosystem