Skip to content

Fix example in Option documentation #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Fix example in Option documentation #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1590c05
docs: fix Option example
mathroc Jul 7, 2025
4fb22f3
Merge branch 'main' into codex/find-and-fix-a-bug-in-codebase
mathroc Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Read the [documentation](https://doc.maybe.texthtml.net) full API description, d
* @return Option<float>
*/
function divide(float $numerator, float $denominator): Option {
return match ($denomintor) {
return match ($denominator) {
0.0 => Option\none(),
default => Option\some($numerator / $denominator),
};
Expand All @@ -40,7 +40,7 @@ $result = divide(2.0, 3.0);
// Pattern match to retrieve the value
if ($result->isSome()) {
// The division was valid
echo "Result: {$option->unwrap()}";
echo "Result: {$result->unwrap()}";
} else {
// The division was invalid
echo "Cannot divide by 0";
Expand Down
6 changes: 3 additions & 3 deletions tools/apigen/theme/pages/index.latte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
* @param Option<float>
*/
function divide(float $numerator, float $denominator): Option {
return match ($denomintor) {
return match ($denominator) {
0.0 => Option\none(),
_ => Option\some($numerator / $denominator)
default => Option\some($numerator / $denominator),
};
}

Expand All @@ -53,7 +53,7 @@ $result = divide(2.0, 3.0);
// Pattern match to retrieve the value
if ($result instanceof Option\Some) {
// The division was valid
echo "Result: {$option->unwrap()}");
echo "Result: {$result->unwrap()}";
} else {
// The division was invalid
echo "Cannot divide by 0";
Expand Down