-
Notifications
You must be signed in to change notification settings - Fork 11
fix: moderninze browse page (credit: @fercamoub, addressing ci/cd iss… #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughComprehensive redesign of the browse page CSS in tcf_website/static/browse/browse.css, adding gradients, shadows, responsive grids, animations, accessibility focus styles, and hover effects. Introduces revamped card layout, headers, department grids, collapse transitions, loading shimmer, and multiple breakpoint-specific adjustments. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tcf_website/static/browse/browse.css (1)
16-27: Remove duplicate border declarations in.school.The
.schoolblock setsborder: none;and then redefinesborderlater in the same rule. This redundancy trips the linter and can confuse future readers. Drop the initial declaration and keep the final one that reflects the intended styling. Based on static analysis hints.- border: none; - border-radius: 16px; + border-radius: 16px; overflow: hidden; background: linear-gradient(145deg, #ffffff 0%, #f8f9fa 100%); box-shadow: 0 4px 6px -1px rgba(0, 0, 0, 0.1), 0 2px 4px -1px rgba(0, 0, 0, 0.06); transition: all 0.4s cubic-bezier(0.4, 0, 0.2, 1); margin-bottom: 0; position: relative; - border: 1px solid rgba(255, 255, 255, 0.2); + border: 1px solid rgba(255, 255, 255, 0.2);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tcf_website/static/browse/browse.css(1 hunks)
🧰 Additional context used
🪛 Biome (2.1.2)
tcf_website/static/browse/browse.css
[error] 26-26: Duplicate properties can lead to unexpected behavior and may override previous declarations unintentionally.
border is already defined here.
Remove or rename the duplicate property to ensure consistent styling.
(lint/suspicious/noDuplicateProperties)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: django
- GitHub Check: pylint
CREDIT TO @fercamoub
Testing fix to CI/CD
Fix browse page #1129
What I did
Screenshots
Testing
-Loaded data from csv and tested multiple screen sizes
Summary by CodeRabbit