Skip to content

Conversation

6007135
Copy link

@6007135 6007135 commented Jul 22, 2025

Document changes in theos/pull/845 and nic/pull/20.

Copy link

netlify bot commented Jul 22, 2025

Deploy Preview for theos-site ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7129493
🔍 Latest deploy log https://app.netlify.com/projects/theos-site/deploys/687f2b2e83cf48000863cebd
😎 Deploy Preview https://deploy-preview-84--theos-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@L1ghtmann L1ghtmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending approval of two aforementioned prs, looks good! Have one unrelated comment. Thanks again for putting this together.

## .nicrc
NIC reads configuration data from `~/.nicrc`. This file uses a simple key-value format, `key = "value"`. Values must be enclosed in quotes, even if it is a number.
## nicrc
NIC configuration data can be stored in a config file to pre-fill values for templates. A simple key-value format is used: `key = "value"`. Values must be enclosed in quotes, even if it is a number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Know this is unrelated to your changes, but the tense here bugs me:

Suggested change
NIC configuration data can be stored in a config file to pre-fill values for templates. A simple key-value format is used: `key = "value"`. Values must be enclosed in quotes, even if it is a number.
NIC configuration data can be stored in a config file to pre-fill values for templates. A simple key-value format is used: `key = "value"`. Values must be enclosed in quotes, even if they are numbers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@6007135
Copy link
Author

6007135 commented Jul 29, 2025

Great. Once theos/pull/845 is finalized, I'll push the wording change along with whatever we decide there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants