Lazily remove exited tasks from run queue #1095
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids locking all the schedulers on task exit. This PR also technically changes the round robin scheduler algorithm, as blocked tasks are now moved to the end of the run queue. Previously, the blocked tasks would be kept in place, aside from the task at the front of the queue which would be switched with the next runnable task using `swap_remove_front`. Signed-off-by: Klim Tsoutsman <[email protected]>
tsoutsman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids locking all the schedulers on task exit.
This PR also technically changes the round robin scheduler algorithm, as blocked tasks are now moved to the end of the run queue. Previously, the blocked tasks would be kept in place, aside from the task at the front of the queue which would be switched with the next runnable task using
swap_remove_front.