- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 180
 
Add 'less' Text Pagination Functionality to Dynamically View Parts of Large Text #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            nnh12
  wants to merge
  56
  commits into
  theseus-os:theseus_main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
nnh12:nathan/less-shell
  
      
      
   
  
    
  
  
  
 
  
      
    base: theseus_main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR restores the
lessfunctionality. This displays a small section of text at a time to make viewing large files easier and interactively via theUpandDownkey.Note: Previous implementation relied on
app_ioto grab a reference to the current terminal and keyboard. However,app_io::get_my_terminal()andapp_io::take_key_event_queue()can no longer be supported or re-added due to code structuring. This is why I added the code to theshellapplication, which already has access to the current terminal and keyboard.Use the
UpandDownkey to scroll through text andQkey to quitlessmode. Below are some test cases. I addedopning_crawl_all.txtfor a large file for test.(Used
Downarrow key to scroll through rest of text).(Using
Upkey to scroll up).