Skip to content

Conversation

Copy link

Copilot AI commented Dec 12, 2025

Multiple core modules import PIL but pillow wasn't declared as a dependency, causing import failures for fresh installs.

Changes

  • Added pillow to the dependencies list in pyproject.toml

Affected modules

  • tinker_cookbook/image_processing_utils.py
  • tinker_cookbook/renderers.py
  • tinker_cookbook/recipes/vlm_classifier/data.py
  • tinker_cookbook/recipes/vlm_classifier/eval.py
Original prompt

Do we need to add pillow to pyproject in tinker-cookbook after the PR I landed? if so let's do it


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Add Pillow to pyproject in tinker-cookbook Add pillow to pyproject.toml dependencies Dec 12, 2025
Copilot AI requested a review from rowanz December 12, 2025 22:08
@rowanz rowanz requested a review from markjen December 12, 2025 22:11
@rowanz rowanz marked this pull request as ready for review December 12, 2025 22:11
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Claude finished @Copilot's task in 36s —— View job


Review Complete

  • Analyze the PR changes
  • Review the pyproject.toml modification
  • Verify affected modules actually import PIL
  • Provide review feedback

LGTM!

This is a correct and necessary fix. The PR adds pillow to the dependencies list in pyproject.toml, which is required because 4 modules in the codebase import from PIL:

File Import
tinker_cookbook/renderers.py:13 from PIL import Image
tinker_cookbook/image_processing_utils.py:13 from PIL import Image
tinker_cookbook/recipes/vlm_classifier/data.py:16 from PIL import Image
tinker_cookbook/recipes/vlm_classifier/eval.py:4 from PIL import Image

The placement is correct (alphabetically sorted in the dependencies list), and this will fix import failures for fresh installs that don't have pillow installed through other means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants