Updating the maximum blips in a ring limit #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbhatnagar97
force-pushed
the
master
branch
3 times, most recently
from
5c876b4 to
a32cace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explored Limits in Default State
Configuration: maxBlipsInRings: [20, 33, 21, 21] from the config file.
These values will prevent blip overlap like shown in the image below
Observation: If the limit of any ring is increased beyond these numbers, blips might not be plotted at all. Therefore, the limits in the config file should not be exceeded.
Hence, we must not exceed these limits in the config file.