Change solana destination address encoding #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide the wallet master address instead of the ATA directly. The expected ATA is derived from the master address provided during processing. To remain backwars compatible, reshuffle the check to see if we've already minted to the beginning of the mint function (and mint sign function in cosigners), and add a function to check if this tx has already been refunded after that. Especially the latter is important since previously refunded txes would now be valid, causing the check to see if the refund already happened to not happen as that lives specifically in the refund handler, which would not be invoked in this case. Signed-off-by: Lee Smet <[email protected]>
LeeSmet
force-pushed
the
solana_master_address
branch
from
90313b5 to
1eca476
Compare
Signed-off-by: Lee Smet <[email protected]>
The exposed call assumes usage of the regular token program, while we use Token2022 Signed-off-by: Lee Smet <[email protected]>
In the mint tx and the request the ATA itself is passed, the stellar tx obviously contains the master. This allows us to also check if the derivation was done properly. Signed-off-by: Lee Smet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the wallet master address instead of the ATA directly. The expected ATA is derived from the master address provided during processing.
To remain backwars compatible, reshuffle the check to see if we've already minted to the beginning of the mint function (and mint sign function in cosigners), and add a function to check if this tx has already been refunded after that. Especially the latter is important since previously refunded txes would now be valid, causing the check to see if the refund already happened to not happen as that lives specifically in the refund handler, which would not be invoked in this case.