-
Notifications
You must be signed in to change notification settings - Fork 103
feat: Support images and PDFs in tool results #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gadenbuie
wants to merge
9
commits into
main
Choose a base branch
from
feat/tool-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving these content types out of the tool results and into the abstract user turn
This better links the content to its source, but generally hides the markup from user view (shinychat doesn't show the XML tags in assistant output).
gadenbuie
commented
Aug 27, 2025
simonpcouch
added a commit
to simonpcouch/bluffbench
that referenced
this pull request
Oct 10, 2025
simonpcouch
added a commit
to tidyverse/vitals
that referenced
this pull request
Oct 10, 2025
Rather than the ad-hoc AsIs data structure, adopt tidyverse/ellmer#735's approach
simonpcouch
added a commit
to simonpcouch/bluffbench
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for tool results to return images or PDF results.
This isn't a feature that's widely supported in provider APIs, but we get around this limitation by moving image and PDF content out of the tool result and into the abstract user turn that carries the tool results.
We support two cases:
content_image()
orcontent_pdf()
as a tool result.In all cases, we replace the value in the tool result with
"[see below]"
(or"[see below: item N]"
in the list case) and we wrap the extra content in<content tool-call-id="abc123" item="N">...content...</content>
XML tags.Notes
as_json()
methods forTurn
and updated them to returntool_message, user_message
.tool_string()
doesn't support having these content types in the tool result because it callsjsonlite::toJSON()
. I updated this function so that internally we can force the JSON conversion for printing, but require this work for the actual tool results that we send across the wire. If it fails, it now fails with a more informative error message. (Internally we call this function when echoing the tool result, before we've pulled out the content types.)Example