Skip to content

Add translate_string_shape to GeomSf #6039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Add translate_string_shape to GeomSf #6039

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6aca63
Add translate_string_shape to GeomSf. Fixes #5808
sierrajohnson Aug 15, 2024
d74642a
news update
sierrajohnson Aug 15, 2024
57ba39a
Merge branch 'main' into geomsf-updateshape
thomasp85 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# ggplot2 (development version)

* geom_sf now accepts shape names (@sierrajohnson, #5808)
* Missing values from discrete palettes are no longer translated
(@teunbrand, #5929).
* Fixed bug in `facet_grid(margins = TRUE)` when using expresssions
Expand Down
3 changes: 3 additions & 0 deletions R/geom-sf.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ GeomSf <- ggproto("GeomSf", Geom,
if (!inherits(coord, "CoordSf")) {
cli::cli_abort("{.fn {snake_class(self)}} can only be used with {.fn coord_sf}.")
}
if (is.character(data$shape)) {
data$shape <- translate_shape_string(data$shape)
}

data <- coord$transform(data, panel_params)

Expand Down