Skip to content

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Aug 22, 2025

Recent versions of libxml2 have some changes, making it a bit more strict. This CI will reproduce a problem that currently happens on CRAN because Debian-14 includes libxml2 2.14.5.

While we're at it, we also test with some more versions of libxml2.

Bisaloo added a commit to Huber-group-EMBL/biomaRt that referenced this pull request Aug 28, 2025
@jeroen
Copy link
Contributor Author

jeroen commented Aug 28, 2025

I think the unit test was broken. The first argument of minimal_html() is an html snippet, but instead it was being passed to the <title> element.

The new libxml2 disallows injecting a <form> inside into a <title> element.

@jeroen jeroen force-pushed the debian14 branch 4 times, most recently from 06230d6 to 25944ef Compare August 28, 2025 14:26
@jeroen jeroen changed the title Test on some more libxml2 versions Fix and test for new libxml2 2.14 Aug 28, 2025
@hadley hadley merged commit 6d853ae into tidyverse:main Aug 29, 2025
21 checks passed
@jeroen jeroen deleted the debian14 branch August 29, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants