Skip to content

Conversation

Copy link

Copilot AI commented Sep 12, 2025

This PR updates all references of ProviderDockerEE to ProviderMKE throughout the codebase to reflect the rebranding of Docker Enterprise Edition to Mirantis Kubernetes Engine (MKE).

Changes Made

  • API Changes: Renamed the ProviderDockerEE constant to ProviderMKE in api/v1/installation_types.go
  • Method Rename: Updated IsDockerEE() method to IsMKE()
  • Controller Updates: Updated all controller logic to use the new constant and method names
  • Render Package Updates: Updated all render components to use the new MKE references
  • Test Updates: Updated test files with new constant references and descriptions
  • Documentation: Updated comments and documentation to use "MKE" instead of "DockerEE"

Backward Compatibility

This change maintains full backward compatibility:

  • The string value remains "DockerEnterprise" to preserve CRD compatibility
  • Existing configurations using "DockerEnterprise" continue to work unchanged
  • No breaking changes to the external API

Files Changed

  • api/v1/installation_types.go - Core API definitions
  • pkg/controller/installation/core_controller.go - Installation controller logic
  • pkg/controller/k8sapi/k8s-endpoint.go - K8s API endpoint handling
  • pkg/controller/utils/discovery.go - Provider discovery logic
  • pkg/render/node.go - Node rendering with MKE-specific configurations
  • pkg/render/applicationlayer/applicationlayer.go - Application layer rendering
  • pkg/render/compliance.go - Compliance component rendering
  • pkg/render/logstorage/eck/eck.go - ECK log storage rendering
  • Multiple test files with updated references and test descriptions

Testing

All existing tests continue to pass, confirming that:

  • Provider detection works correctly for MKE clusters
  • MKE-specific configurations (VXLAN VNI, BPF settings, etc.) are applied properly
  • Cluster admin role bindings are created correctly for MKE environments
  • No regressions in functionality

This change improves code clarity by using the current product name while maintaining full compatibility with existing deployments.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • get.helm.sh
    • Triggering command: curl -fsSL --retry 5 REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

This pull request was created as a result of the following prompt from Copilot chat.

Update all occurrences of 'ProviderDockerEE' to 'ProviderMKE' across all files in the repository. Ensure that this replacement does not break any functionality or references, and update relevant comments, documentation, and tests accordingly. Run the test suite if present to verify successful changes.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@marvin-tigera marvin-tigera added this to the v1.40.0 milestone Sep 12, 2025
Copilot AI changed the title [WIP] Replace ProviderDockerEE with ProviderMKE in codebase Update ProviderDockerEE to ProviderMKE across codebase Sep 12, 2025
Copilot AI requested a review from sridhartigera September 12, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants